program: introduce core BPF implementation

[buffalojoec]

This PR introduces the Core BPF implementation of Address Lookup Table.

There are a few caveats with the implementation so far. You can find them in the
source code by searching for comments prefixed with:

[Core BPF]:

The following caveats will be solved in the next Solana release, and a
discussion can be had for backporting any of these changes:

• InstructionError::Immutable has no ProgramError counterpart
  (#35113).
• InstructionError::IncorrectAuthority has no ProgramError counterpart
  (#35113).
• solana-program-test will not overwrite a builtin if the BPF program you've
  provided shares the same address as an existing builtin
  (#35233).

The following caveat seems to be unavoidable:

• The build.rs script and annotations in lib.rs are required for
  solana-frozen-abi-macro (See Determine proper build script and Frozen ABI compatibility #3).

Finally, I've implemented a cooldown period based on Clock, but this will
likely not be sufficient. I think we should consider merging this initial
implementation and leaving #1 unfinished until the proper research is completed.

[buffalojoec]

• program: integrate shank #9
• program: introduce core BPF tests #8
• program: introduce core BPF implementation #7 👈
• program: wipe directory contents #10
• repo: bump solana crates to 1.18.2 #6
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @buffalojoec and the rest of your teammates on Graphite

[joncinque]

Looks really good for the most part! Lots of comments, but mostly small things

[joncinque]

nit: are we going with solana-program-address-lookup-table?

[lorisleiva]

I think we can do better. I'd love us to commit on a good naming convention. Our current one is:

Organization name:      solana-program
Program name:           address-lookup-table
Program crate name:     solana-program-address-lookup-table
Rust client crate name: solana-program-address-lookup-table-client
JS client package name: @solana-program/address-lookup-table

I like the JS client package name but maybe the crates are a bit too verbose. We could replace solana-program- with something like spl- for crate names but then we risk to have conflicts with existing ones.

Cc @steveluscher @mcintyre94

[buffalojoec]

What about just sp-?

[buffalojoec]

I guess for any programs we port over from SPL land, sp would be royally confusing.

[joncinque]

yeah... we haven't been able to come up with anything better. The crate is currently called solana-address-lookup-table-program so I'm not too fussed about solana-program-address-lookup-table, unless we want to create a new acronym to make it totally clear that it's different.

I haven't liked anything enough to push for it. I don't think we should use spl- though, that means something different. The best might be to use sbpf in it, so I could (weakly) vouch for sbpf-address-lookup-table-program

[buffalojoec]

I went with scbpf- for now, but let's see where we land in talks. Lmk if this should block merging. Ideally we aren't publishing anytime soon.

[joncinque]

That's fine, we can stick with that

[lorisleiva]

For anyone reading this, the conversation continued here:
https://discord.com/channels/428295358100013066/1204657211402489876/1215666108141539358

[buffalojoec]

@joncinque I believe I've addressed everything here in some follow-up commits. Just need to land on the crate name.

[joncinque]

Looks good to me! Thanks for integrating all the feedback, you really... crushed it:

[joncinque]

All right, good to go on my side!

[buffalojoec]

Merge activity

• Mar 13, 12:16 AM EDT: @buffalojoec started a stack merge that includes this pull request via Graphite.
• Mar 13, 12:24 AM EDT: Graphite rebased this pull request as part of a merge.
• Mar 13, 12:25 AM EDT: @buffalojoec merged this pull request with Graphite.