This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix cluster collapse due to no proper shifted read#7797
Merged
ryoqun merged 2 commits intosolana-labs:masterfrom Jan 15, 2020
Merged
Fix cluster collapse due to no proper shifted read#7797ryoqun merged 2 commits intosolana-labs:masterfrom
ryoqun merged 2 commits intosolana-labs:masterfrom
Conversation
Contributor
|
nice work @ryoqun! |
Contributor
Author
|
ref: #5573 |
Merged
Contributor
|
Good sleuthing! |
Contributor
|
Great find! |
Codecov Report
@@ Coverage Diff @@
## master #7797 +/- ##
========================================
- Coverage 81.9% 81.9% -0.1%
========================================
Files 241 238 -3
Lines 51133 51130 -3
========================================
- Hits 41902 41898 -4
- Misses 9231 9232 +1 |
mergify Bot
pushed a commit
that referenced
this pull request
Jan 15, 2020
* Fix cluster collapse due to no proper shifted read * Add test for bank hash mismatch Co-authored-by: sakridge <sakridge@gmail.com> (cherry picked from commit b16c30b)
solana-grimes
pushed a commit
that referenced
this pull request
Jan 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sakridge
TBD; My stamina is exhausted; there is moderate number of issues/PRs to submit and tests to write; Those are needed to get here... It was very long journey... ;)
Introduced by months ago: https://github.com/solana-labs/solana/pull/5573/files#diff-2099c5256db4eb5975c8834af38f6456R782.
It seems TdS DR6 finally managed to expose this bug.
The findings at #7736 are now all clear; Every mysterious pieces are put together in place.
And no wonder if this thing happens randomly on several validators with enough stake at the same time, this indeed will lead to mismatched bank hashes across the cluster and the inevitable total consensus failure.
Fixes #7736