This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Bank hash xor#5573
Merged
sakridge merged 1 commit intosolana-labs:masterfrom Sep 20, 2019
Merged
Conversation
sakridge
force-pushed
the
bank-hash-xor
branch
2 times, most recently
from
f1cb450 to
7c53ff8
Compare
rob-solana
reviewed
Aug 22, 2019
rob-solana
reviewed
Aug 22, 2019
rob-solana
reviewed
Aug 22, 2019
sakridge
force-pushed
the
bank-hash-xor
branch
from
7c53ff8 to
84d1878
Compare
Contributor
|
yeah, what you're touching is exactly what I'm touching :-( should be fun. |
Contributor
Author
Would it help you think if we just merged a smaller PR with the BankHash and SlotHash types where BankHash is typedef'ed to just Hash for now? |
rob-solana
reviewed
Aug 22, 2019
sakridge
force-pushed
the
bank-hash-xor
branch
3 times, most recently
from
edd20da to
bc6b287
Compare
Contributor
|
the conflict we'll have is with load()'s signature no need to avoid each other, I could use the merge practice |
sakridge
force-pushed
the
bank-hash-xor
branch
8 times, most recently
from
66363e0 to
308859d
Compare
Codecov Report
@@ Coverage Diff @@
## master #5573 +/- ##
========================================
- Coverage 71.7% 70.1% -1.6%
========================================
Files 236 237 +1
Lines 43274 44571 +1297
========================================
+ Hits 31033 31253 +220
- Misses 12241 13318 +1077 |
sakridge
force-pushed
the
bank-hash-xor
branch
7 times, most recently
from
5727e90 to
9271902
Compare
sakridge
force-pushed
the
bank-hash-xor
branch
3 times, most recently
from
15e93b0 to
cdee022
Compare
rob-solana
reviewed
Sep 17, 2019
rob-solana
reviewed
Sep 17, 2019
sakridge
force-pushed
the
bank-hash-xor
branch
from
cdee022 to
89c583d
Compare
sakridge
force-pushed
the
bank-hash-xor
branch
2 times, most recently
from
c2eeba5 to
a6058f7
Compare
sakridge
force-pushed
the
bank-hash-xor
branch
from
a6058f7 to
0fa6e60
Compare
sakridge
requested review from
rob-solana and
t-nelson
and removed request for
carllin
t-nelson
reviewed
Sep 20, 2019
t-nelson
approved these changes
Sep 20, 2019
ryoqun
reviewed
Jan 14, 2020
| let rvs = storage.accounts.append_accounts(&with_meta[infos.len()..]); | ||
| let rvs = storage | ||
| .accounts | ||
| .append_accounts(&with_meta[infos.len()..], &hashes); |
brooksprumo
added a commit
to brooksprumo/solana
that referenced
this pull request
Oct 23, 2024
original pr: solana-labs#5573 pr that added bank3: solana-labs#7892
brooksprumo
added a commit
to brooksprumo/solana
that referenced
this pull request
Oct 23, 2024
original pr: solana-labs#5573 pr that added bank3: solana-labs#7892
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hash_internal_state is slow and doesn't allow for incremental state checking.
Summary of Changes
Hash account state on load/store and then xor with an accumulator to create the bank hash.
Fixes #