This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Snapshot optimizations#5525
Merged
Merged
Conversation
carllin
force-pushed
the
SnapshotOptimizations
branch
from
d98ee47 to
ae7cb51
Compare
mvines
reviewed
Aug 14, 2019
| .suffix(".tgz") | ||
| .tempfile_in(tar_dir)?; | ||
| let temp_tar_path = temp_tar_gz.path(); | ||
| let mut args = vec!["zcfhS"]; |
Contributor
There was a problem hiding this comment.
This'll be j instead of z (and tar_bz2) once #5515 lands
Codecov Report
@@ Coverage Diff @@
## master #5525 +/- ##
========================================
- Coverage 76.1% 73.9% -2.3%
========================================
Files 214 214
Lines 41285 42501 +1216
========================================
- Hits 31452 31427 -25
- Misses 9833 11074 +1241 |
carllin
force-pushed
the
SnapshotOptimizations
branch
from
ae7cb51 to
dccb902
Compare
carllin
force-pushed
the
SnapshotOptimizations
branch
from
dccb902 to
963f117
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Serialization in Rust tar does not support adding sparse files and crashes on archives bigger than 4GB
Summary of Changes
Call a shell command to tar snapshots instead.
Fixes #