This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Move genesis/snapshot archive download into Rust#5515
Merged
mvines merged 1 commit intosolana-labs:masterfrom Aug 15, 2019
Merged
Move genesis/snapshot archive download into Rust#5515mvines merged 1 commit intosolana-labs:masterfrom
mvines merged 1 commit intosolana-labs:masterfrom
Conversation
Contributor
Author
|
hmm, looks like I broke some snapshot tests somehow 🔍 |
57ec26a to
6b614d7
Compare
Contributor
Author
|
rocksdb!!!! 🤕 |
ad7c636 to
da5366b
Compare
This was referenced Aug 14, 2019
Merged
carllin
reviewed
Aug 14, 2019
| .takes_value(true) | ||
| .help("Rendezvous with the cluster at this entry point"), | ||
| ) | ||
| .arg( |
Contributor
There was a problem hiding this comment.
is this the same as not providing the snapshot_interval_slots argument?
Contributor
Author
There was a problem hiding this comment.
Will rename to --no-fetch-snapshot
Contributor
Author
|
Note to self: snapshots_tar_dir needs to be set to ledger dir |
Codecov Report
@@ Coverage Diff @@
## master #5515 +/- ##
========================================
- Coverage 77.3% 74.9% -2.4%
========================================
Files 213 214 +1
Lines 40639 41902 +1263
========================================
- Hits 31417 31416 -1
- Misses 9222 10486 +1264 |
Contributor
Waaay long back comment, but I fixed this in the upstream btw: rust-rocksdb/rust-rocksdb#339 Found this pr searching about rocksdb by #10209 :) |
Contributor
Author
|
solid, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solana-validatoris now fully usable stand-alone without thevalidator.shcrutch