Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Reorg#47

Merged
garious merged 10 commits intosolana-labs:masterfrom
garious:add-transaction-struct
Mar 6, 2018
Merged

Reorg#47
garious merged 10 commits intosolana-labs:masterfrom
garious:add-transaction-struct

Conversation

@garious
Copy link
Copy Markdown
Contributor

@garious garious commented Mar 6, 2018

Trying to look more like a Rust programmer than a Haskell programmer.

garious added 10 commits March 6, 2018 10:50
This will allow us to add addition transfer types to the log.
Now that Transfer is out of the enum, we don't need to pattern
match to access its fields.
Far fewer branches when we process transfers outside the context
of events.
struct names should be nouns
A little overly-coupled to Serialize, but makes the code a lot tighter
Because things other than transactions can be signed.
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #47 into master will increase coverage by 13.02%.
The diff coverage is 95.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #47       +/-   ##
===========================================
+ Coverage   82.42%   95.44%   +13.02%     
===========================================
  Files          14       11        -3     
  Lines         876      747      -129     
===========================================
- Hits          722      713        -9     
+ Misses        154       34      -120
Impacted Files Coverage Δ
src/lib.rs 100% <ø> (ø) ⬆️
src/historian.rs 100% <100%> (ø) ⬆️
src/signature.rs 100% <100%> (ø)
src/log.rs 98.62% <100%> (ø) ⬆️
src/logger.rs 97.82% <100%> (ø) ⬆️
src/event.rs 100% <100%> (ø) ⬆️
src/transaction.rs 100% <100%> (ø)
src/genesis.rs 89.18% <100%> (ø) ⬆️
src/accountant_skel.rs 80% <42.85%> (+3.63%) ⬆️
src/accountant_stub.rs 90.81% <66.66%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9af5a...624c151. Read the comment docs.

@garious garious merged commit c231331 into solana-labs:master Mar 6, 2018
vkomenda referenced this pull request in vkomenda/solana Aug 29, 2021
* Token: add Rust program id and bump version

* Exclude js from package

* C header bump
ryleung-solana pushed a commit to ryleung-solana/solana that referenced this pull request Jan 22, 2024
use the cli from appropriate release channel for all solana cli commands
brooksprumo added a commit to brooksprumo/solana that referenced this pull request Mar 4, 2024
willhickey pushed a commit that referenced this pull request Mar 5, 2024
segfaultdoc pushed a commit to jito-labs/solana that referenced this pull request Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants