Adds a bench for hash_account()#47
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Mar 4, 2024
Merged
Conversation
brooksprumo
commented
Mar 4, 2024
Comment on lines
+12
to
+13
| 165, // the size of an spl token account | ||
| 200, // the size of a stake account |
Author
There was a problem hiding this comment.
Since accounts in this size range make up ~90% of all accounts on mnb, we should optimize hashing for them. In order to quantify any improvements, we gotta benchmark it!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 837 837
Lines 225922 225922
=========================================
- Hits 184955 184888 -67
- Misses 40967 41034 +67 |
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While tweaking the implementation for
AccountsDb::hash_account_data(), I didn't have a way to benchmark my changes to see if there were any improvements.Summary of Changes
Add a bench for
hash_account().Details
After running the benchmark, criterion displays useful information. Here's an example of the text results:
And here's two of the many webpages that gets produced.