This repository was archived by the owner on Jan 22, 2025. It is now read-only.
PrunedBanksRequestHandler::handle_request() is only pub with dcou#33155
Merged
mergify[bot] merged 1 commit intosolana-labs:masterfrom Sep 6, 2023
Merged
Conversation
brooksprumo
force-pushed
the
pruned-banks-handler/dcou
branch
from
79d88a5 to
88cb268
Compare
brooksprumo
force-pushed
the
pruned-banks-handler/dcou
branch
from
88cb268 to
8ed0f45
Compare
brooksprumo
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #33155 +/- ##
=======================================
Coverage 82.0% 82.1%
=======================================
Files 785 785
Lines 211122 211196 +74
=======================================
+ Hits 173328 173404 +76
+ Misses 37794 37792 -2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PrunedBanksRequestHandler::handle_request()is only meant to be called from AccountsBackgroundService, but it is public so that bank tests can call it. Now that we have DCOU, we no longer need for this function to be pub for non-tests.Summary of Changes
PrunedBanksRequestHandler::handle_request()is only public when in dev context.