This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Removes invariant is_serialized_with_abs param#33154
Merged
brooksprumo merged 1 commit intosolana-labs:masterfrom Sep 6, 2023
Merged
Conversation
3cfd172 to
bfd15c7
Compare
jeffwashington
approved these changes
Sep 6, 2023
Contributor
jeffwashington
left a comment
There was a problem hiding this comment.
lgtm
would be useful to look at 1.14 or something and see when it was used and how its use got removed (if ever). maybe that was a mistake.
Contributor
Author
Looks like this parameter was added back in 2021 here #17319. It has always been The old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PrunedBanksRequestHandler::handle_request()takes a parameter,is_serialized_with_abs, that is always called withtrue. I can't think of a reason why—from this function—we'd want to callAccountsDb::purge_slot()with a different value. So having this parameter seems unnecessary at best, and error-prone at worst.Summary of Changes
Remove the param.