This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add support for optional metric values via Option<_>#31975
Merged
jbiseda merged 1 commit intosolana-labs:masterfrom Jun 5, 2023
Merged
Add support for optional metric values via Option<_>#31975jbiseda merged 1 commit intosolana-labs:masterfrom
jbiseda merged 1 commit intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31975 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 760 760
Lines 207513 207543 +30
=========================================
Hits 170068 170068
- Misses 37445 37475 +30 |
steviez
approved these changes
Jun 5, 2023
Contributor
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
LGTM - thanks for breaking out into separate PR and for the unit test as well!
mergify Bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
(cherry picked from commit 6371240)
jbiseda
added a commit
that referenced
this pull request
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Optionally logging specific values would be useful to reduce metrics spam for default values.
Summary of Changes
Add support to supply metric values as
Option<_>types which will only logSome(_)values.Fixes #