This repository was archived by the owner on Jan 22, 2025. It is now read-only.
rationalize repair type min/max metrics#31805
Merged
jbiseda merged 1 commit intosolana-labs:masterfrom Jun 13, 2023
Merged
Conversation
jbiseda
force-pushed
the
repair-metric-slot-range
branch
from
8c7a3e6 to
22a3c92
Compare
Codecov Report
@@ Coverage Diff @@
## master #31805 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 765 765
Lines 208646 208655 +9
=======================================
+ Hits 170982 171036 +54
+ Misses 37664 37619 -45 |
jbiseda
force-pushed
the
repair-metric-slot-range
branch
from
22a3c92 to
f10a749
Compare
jbiseda
changed the title
jbiseda
force-pushed
the
repair-metric-slot-range
branch
3 times, most recently
from
dc55565 to
49bdc4e
Compare
jbiseda
force-pushed
the
repair-metric-slot-range
branch
from
49bdc4e to
2b3d164
Compare
behzadnouri
reviewed
Jun 1, 2023
behzadnouri
reviewed
Jun 1, 2023
jbiseda
force-pushed
the
repair-metric-slot-range
branch
from
2b3d164 to
7b9883b
Compare
steviez
reviewed
Jun 5, 2023
jbiseda
force-pushed
the
repair-metric-slot-range
branch
2 times, most recently
from
69d61d8 to
4f932b8
Compare
steviez
previously approved these changes
Jun 12, 2023
Contributor
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
I'm good with this as-is. However, let's make sure to get @behzadnouri's sign off / reach consensus in the issue he raised about whether to drop or keep repair-total.
yhchiang-sol
previously approved these changes
Jun 12, 2023
Contributor
yhchiang-sol
left a comment
yhchiang-sol
left a comment
There was a problem hiding this comment.
LGTM. Be sure to get @behzadnouri's approval before merging the PR.
jbiseda
force-pushed
the
repair-metric-slot-range
branch
from
4f932b8 to
12641b6
Compare
steviez
approved these changes
Jun 13, 2023
jeffwashington
pushed a commit
to HaoranYi/solana
that referenced
this pull request
Jun 13, 2023
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Repair slot min/max are collected for each repair type, but min/max across repair types are not uniformly reported.
Summary of Changes
WindowIndex,HighestWindowIndex,Orphanrepair request min/max slot values. Only report non-default values.repair-highest-slotandrepair-orphanvalues for continuity with existing metrics. These data points can eventually be removed.repair-totalmetric. This metric is the sum of existingshred-count,highest-shred-count, andorphan-countvalues.Fixes #