Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

StorageStage now sends transactions at the local TPU#3195

Merged
mvines merged 1 commit intosolana-labs:masterfrom
mvines:store
Mar 8, 2019
Merged

StorageStage now sends transactions at the local TPU#3195
mvines merged 1 commit intosolana-labs:masterfrom
mvines:store

Conversation

@mvines
Copy link
Copy Markdown
Contributor

@mvines mvines commented Mar 8, 2019

The local TPU will forward the transactions as needed if it's not currently the leader.

This reduces the complexity of:

  • the storagestage, it doesn't need to care who the leader is t
  • reduces the users of gossip's notion of a leader (progress towards Remove CrdsValue::LeaderId #3188)

cc: #3193

@mvines mvines requested a review from sakridge March 8, 2019 18:39
Comment thread core/src/storage_stage.rs
) -> io::Result<()> {
if let Some(leader_info) = cluster_info.read().unwrap().leader_data() {
let mut client = mk_client_with_timeout(leader_info, Duration::from_secs(5));
let node_info = cluster_info.read().unwrap().my_data();
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/leader_data/my_data/ on this line is really the only functional change in this PR.

The rest of the patch is just code shifting around and my desire to purge the codebase of "tx" (like does this mean "transaction" or "transmit"...we use "tx" for both!)

Copy link
Copy Markdown
Contributor

@sakridge sakridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2019

Codecov Report

Merging #3195 into master will increase coverage by <.1%.
The diff coverage is 42.8%.

@@           Coverage Diff            @@
##           master   #3195     +/-   ##
========================================
+ Coverage    81.1%   81.2%   +<.1%     
========================================
  Files         129     129             
  Lines       19614   19614             
========================================
+ Hits        15918   15934     +16     
+ Misses       3696    3680     -16

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2019

Codecov Report

Merging #3195 into master will increase coverage by <.1%.
The diff coverage is 42.8%.

@@           Coverage Diff            @@
##           master   #3195     +/-   ##
========================================
+ Coverage    81.1%   81.2%   +<.1%     
========================================
  Files         129     129             
  Lines       19614   19614             
========================================
+ Hits        15918   15934     +16     
+ Misses       3696    3680     -16

@mvines mvines merged commit 12f3fd7 into solana-labs:master Mar 8, 2019
@mvines mvines deleted the store branch March 8, 2019 19:03
Szymongib pushed a commit to ChorusOne/solana that referenced this pull request Oct 28, 2024
…t of solana-labs#3194) (solana-labs#3195)

rolls back chained Merkle shreds for testnet downgrade (solana-labs#3194)

(cherry picked from commit 69916f1)

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants