Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

RPC now sends transactions at the local TPU#3193

Merged
mvines merged 2 commits intosolana-labs:masterfrom
mvines:rpc
Mar 8, 2019
Merged

RPC now sends transactions at the local TPU#3193
mvines merged 2 commits intosolana-labs:masterfrom
mvines:rpc

Conversation

@mvines
Copy link
Copy Markdown
Contributor

@mvines mvines commented Mar 8, 2019

The local TPU will forward the transactions as needed if it's not currently the leader.

This reduces the complexity of:

  • the RPC subsystem, it doesn't need to follow the leader around.
  • reduces the users of gossip's notion of a leader (progress towards Remove CrdsValue::LeaderId #3188)

mvines added 2 commits March 8, 2019 09:57
The local TPU will forward the transactions as needed if it's not
currently the leader
@mvines mvines requested a review from CriesofCarrots March 8, 2019 18:01
@mvines mvines added work in progress This isn't quite right yet and removed work in progress This isn't quite right yet labels Mar 8, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2019

Codecov Report

Merging #3193 into master will decrease coverage by <.1%.
The diff coverage is 77.7%.

@@           Coverage Diff            @@
##           master   #3193     +/-   ##
========================================
- Coverage    81.1%   81.1%   -0.1%     
========================================
  Files         129     129             
  Lines       19614   19601     -13     
========================================
- Hits        15918   15905     -13     
  Misses       3696    3696

@mvines
Copy link
Copy Markdown
Contributor Author

mvines commented Mar 8, 2019

Merging #3193 into master will decrease coverage by <.1%.

Yeah that makes no sense!

@CriesofCarrots
Copy link
Copy Markdown
Contributor

Merging #3193 into master will decrease coverage by <.1%.

Yeah that makes no sense!

The CodeCov numbers seem a bit flaky to me.

@mvines mvines merged commit e04148f into solana-labs:master Mar 8, 2019
@mvines mvines deleted the rpc branch March 8, 2019 19:42
AshwinSekar pushed a commit to AshwinSekar/solana that referenced this pull request Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants