Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Delete files older than the lowest_cleanup_slot in LedgerCleanupService::cleanup_ledger (backport #26651)#28721

Merged
steviez merged 2 commits intov1.13from
mergify/bp/v1.13/pr-26651
Nov 10, 2022
Merged

Delete files older than the lowest_cleanup_slot in LedgerCleanupService::cleanup_ledger (backport #26651)#28721
steviez merged 2 commits intov1.13from
mergify/bp/v1.13/pr-26651

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Nov 2, 2022

This is an automatic backport of pull request #26651 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…ce::cleanup_ledger (#26651)

#### Problem
LedgerCleanupService requires compactions to propagate & digest range-delete tombstones
to eventually reclaim disk space.

#### Summary of Changes
This PR makes LedgerCleanupService::cleanup_ledger delete any file whose slot-range is
older than the lowest_cleanup_slot.  This allows us to reclaim disk space more often with
fewer IOps.  Experimental results on mainnet validators show that the PR can effectively
reduce 33% to 40% ledger disk size.

(cherry picked from commit 99ef218)
@mergify mergify Bot added the automerge Merge this Pull Request automatically once CI passes label Nov 2, 2022
@steviez steviez added no-automerge Prevent the automerge label from being applied and removed automerge Merge this Pull Request automatically once CI passes labels Nov 2, 2022
@steviez steviez self-assigned this Nov 2, 2022
@steviez steviez merged commit 88c87d1 into v1.13 Nov 10, 2022
@steviez steviez deleted the mergify/bp/v1.13/pr-26651 branch November 10, 2022 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-automerge Prevent the automerge label from being applied

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants