This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add RocksSlotTtl storage type: A slot-based FIFO compatible with Level#27567
Closed
yhchiang-sol wants to merge 1 commit intosolana-labs:masterfrom
yhchiang-sol:slot-ttl
Closed
Add RocksSlotTtl storage type: A slot-based FIFO compatible with Level#27567yhchiang-sol wants to merge 1 commit intosolana-labs:masterfrom yhchiang-sol:slot-ttl
yhchiang-sol wants to merge 1 commit intosolana-labs:masterfrom
yhchiang-sol:slot-ttl
Conversation
Contributor
Author
|
Crap. This doesn't work because DeleteFilesInRange does not cover L0. Such a pity :'(. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR introduces ShredStorageType::RocksSlotTtl. The shred storage type
that works similarly to FIFO except it uses a slot-based TTL to purge files and
it's compatible with level compaction.
Under the hood, RocksSlotTtl has no background compaction, and it relies on
the recently introduced #26651 that enables LedgerCleanupService to directly
purge any sst files that are older than both --limit-ledger-size and root.
I am still baking the PR and will soon start running experiments. If the experimental
results sound, then RocksSlotTtl should have similar performance as FIFO but
have a stronger consistency guarantee than FIFO and is compatible with the existing
level compaction.