This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix CPI duplicate account privilege escalation#22752
Merged
Lichtso merged 2 commits intosolana-labs:masterfrom Jan 27, 2022
Merged
Fix CPI duplicate account privilege escalation#22752Lichtso merged 2 commits intosolana-labs:masterfrom
Lichtso merged 2 commits intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22752 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 558 558
Lines 149899 149901 +2
=======================================
+ Hits 122189 122224 +35
+ Misses 27710 27677 -33 |
jstarry
reviewed
Jan 26, 2022
Contributor
jstarry
left a comment
There was a problem hiding this comment.
Fix looks good, would be nice to have separate tests for both original and dupe account privilege escalation though for future protection
ryoqun
previously approved these changes
Jan 27, 2022
Contributor
There was a problem hiding this comment.
lgtm (i second with @jstarry 's comment about separate tests; also backporting only those new tests would be a bonus; i mean it seems that our test suite lacked this duplicate account privilege escalation case in the first case. and that allowed this bug slipped in, right?).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#22107 introduced a privilege escalation bug:
If a CPI uses duplicate
Pubkeys only the privileges of the first were verified.Summary of Changes
TEST_PRIVILEGE_ESCALATION_SIGNERandTEST_PRIVILEGE_ESCALATION_WRITABLEto cover duplicate entries as well.Fixes #