This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Cleanup: invoke_context.rs#22107
Merged
Lichtso merged 3 commits intosolana-labs:masterfrom Dec 25, 2021
Merged
Conversation
4dc29fe to
c775666
Compare
Program and programdata accounts use rposition(), everything else uses position().
c775666 to
5f3bd0c
Compare
Codecov Report
@@ Coverage Diff @@
## master #22107 +/- ##
=========================================
- Coverage 81.3% 81.2% -0.1%
=========================================
Files 519 519
Lines 145736 145732 -4
=========================================
- Hits 118500 118469 -31
- Misses 27236 27263 +27 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow up of #22102, which left some inefficiencies to be optimized.
Summary of Changes
Message::new(&[instruction.clone()], None)by a custominstruction_accountcompilation logic.message::Messagefrom invoke_context.rs completely (including the tests).sol_invoke_signed()of program-test.InvokeContext::find_index_of_account().Fixes #