This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Added TooManyAccountLocks to the PostgreSQL enum types#22348
Merged
lijunwangs merged 1 commit intosolana-labs:masterfrom Jan 7, 2022
Merged
Added TooManyAccountLocks to the PostgreSQL enum types#22348lijunwangs merged 1 commit intosolana-labs:masterfrom
lijunwangs merged 1 commit intosolana-labs:masterfrom
Conversation
Contributor
|
Can we add a test or check that verifies in CI that all TransactionErrors are handled? Otherwise, I foresee this breaking every time someone adds a TransactionError type (like I'm about to do too: de7aed3 ) |
Contributor
Author
Yes @CriesofCarrots -- I am developing the integration tests running in CI. Actually I caught this while testing the integration tests :) I found regressions a couple of times before as well. So the CI test is much needed. |
CriesofCarrots
approved these changes
Jan 7, 2022
1 task
jstarry
approved these changes
Jan 7, 2022
Contributor
jstarry
left a comment
jstarry
left a comment
There was a problem hiding this comment.
Thanks for catching this @lijunwangs, looking forward to have that test
mergify Bot
pushed a commit
that referenced
this pull request
Jan 7, 2022
Checked w/o waiting for the CI result as currently CI is not validating Postgres changes. Manually verified it fixed the issue (cherry picked from commit b2687b7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Failed to persist the update of transaction info to the PostgreSQL database due to Rust and PostgreSQL type mist matches
Summary of Changes
Added TooManyAccountLocks to the PostgreSQL enum types
Fixes #