Prevent rent-paying account creation by CriesofCarrots · Pull Request #22292 · solana-labs/solana

CriesofCarrots · 2022-01-05T06:18:27Z

Problem

A single epoch's worth of rent for an account with data is too little relative to the costs of storing that data.

Summary of Changes

Compare rent-exemption status pre- and post-processing; fail if any end up RentPaying that didn't start that way.

Needs rebase on Added TooManyAccountLocks to the PostgreSQL enum types #22348 and new Tx error added

CriesofCarrots · 2022-01-05T19:59:22Z

@jstarry , can you please start looking at this when you have a minute? (There are a bunch of tests that assume it's okay to create rent-paying accounts, so still lots of fixup before formally ready)

To answer your question from here (#21142 (comment), and I'm sorry for taking so long to do so!), I prefer this location because this is where the execution result is still being determined, ie. mutable. This actually seems even more stark to me after your refactor; the execution result should be set and unmutable after execute_loaded_transaction()

Also, in order to allow legacy rent-paying accounts, we need to know the state before execution, which will be clunky to pass along to collect_accounts_to_store.

(edit) However, your point about only examining writable accounts is a fair one. Added a commit to do this. Could potentially remove the RentState::NativeOrSysvar variant now.

jstarry

Direction looks good to me! Nice that tx fees are still charged

CriesofCarrots · 2022-01-07T20:49:47Z

Less the assert, this is ready for real review! All the test churn should be confined to the one commit "Fix rpc tests...", so feel free to ignore that one.

jstarry

Looks good, main concern now is how this impacts users who rely on or incidentally create rent-paying accounts.

Pull request has been modified.

ryoqun · 2022-01-10T13:33:38Z

i'll keep my eyes on this. maybe we need to advice all exchanges/wallets beforehand about this upcoming change as this will forbid these kinds of affected small SOL transfers. (anyway, these transfers should be erroneous to begin with).

how about adding a small section here: docs/src/integrations/exchange.md (or, i can do as a follow-up).

solana-labs#22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced.

#22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced.

#22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced. (cherry picked from commit c99d9f0) # Conflicts: # runtime/src/accounts.rs # runtime/src/bank.rs # runtime/src/expected_rent_collection.rs # runtime/src/rent_collector.rs

#22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced. (cherry picked from commit c99d9f0)

* names fields in RentResullt::CollectRent enum variant (#26449) Avoiding ambiguous raw tuple: CollectRent((Epoch, u64)) Using named fields instead: CollectRent { new_rent_epoch: Epoch, rent_due: u64, }, (cherry picked from commit d7201a8) # Conflicts: # runtime/src/bank.rs # runtime/src/expected_rent_collection.rs # runtime/src/rent_collector.rs * removes mergify merge conflicts * preserves rent_epoch for rent exempt accounts (#26479) #22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced. (cherry picked from commit c99d9f0) Co-authored-by: behzad nouri <behzadnouri@gmail.com>

solana-labs#22292

solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. This commit restricts rent-paying accounts TTL extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.

solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts TTL extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.

solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifeline extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.

#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifetime extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.

#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifetime extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum. (cherry picked from commit bf225ba) # Conflicts: # runtime/src/account_rent_state.rs # runtime/src/accounts.rs # runtime/src/bank/transaction_account_state_info.rs # sdk/src/feature_set.rs

…26635) * restricts rent-paying accounts lifetime extension (#26606) #22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifetime extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum. (cherry picked from commit bf225ba) # Conflicts: # runtime/src/account_rent_state.rs # runtime/src/accounts.rs # runtime/src/bank/transaction_account_state_info.rs # sdk/src/feature_set.rs * removes mergify merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>

solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifetime extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.

CriesofCarrots changed the title ~~Prevent rent paying account creation~~ Prevent rent-paying account creation Jan 5, 2022

CriesofCarrots force-pushed the prevent-rent-paying-account-creation branch 2 times, most recently from 58926e0 to 9f4918f Compare January 5, 2022 06:41

CriesofCarrots force-pushed the prevent-rent-paying-account-creation branch 2 times, most recently from c02d320 to f0eb930 Compare January 6, 2022 02:47

jstarry reviewed Jan 6, 2022

View reviewed changes

Comment thread runtime/src/account_rent_state.rs Outdated

jstarry reviewed Jan 6, 2022

View reviewed changes

Comment thread runtime/src/bank.rs Outdated

jstarry reviewed Jan 6, 2022

View reviewed changes

Comment thread runtime/src/bank.rs Outdated

CriesofCarrots force-pushed the prevent-rent-paying-account-creation branch 9 times, most recently from 0fd398e to de7e748 Compare January 7, 2022 20:03

CriesofCarrots marked this pull request as ready for review January 7, 2022 20:17

CriesofCarrots force-pushed the prevent-rent-paying-account-creation branch from de7e748 to 00c5873 Compare January 7, 2022 23:20

jstarry previously approved these changes Jan 8, 2022

View reviewed changes

Comment thread runtime/src/account_rent_state.rs

Comment thread runtime/src/bank/transaction_account_state_info.rs

Comment thread runtime/src/account_rent_state.rs Outdated

CriesofCarrots force-pushed the prevent-rent-paying-account-creation branch from 00c5873 to 40145c3 Compare January 8, 2022 02:48

CriesofCarrots added the v1.9 label Jan 8, 2022

This was referenced Jan 8, 2022

Fixup tests to use rent-exempt accounts solana-labs/solana-program-library#2717

Merged

Fix up helper to create rent-exempt accounts solana-labs/solana-program-library#2720

Merged

ryoqun reviewed Jan 10, 2022

View reviewed changes

Comment thread runtime/src/account_rent_state.rs

behzadnouri mentioned this pull request Jul 7, 2022

preserves rent_epoch for rent exempt accounts #26479

Merged

behzadnouri mentioned this pull request Jul 8, 2022

Feature Gate: preserves rent_epoch for rent exempt accounts #26509

Closed

behzadnouri added a commit to behzadnouri/solana that referenced this pull request Jul 13, 2022

restricts rent-paying accounts TTL extension

84d3920

solana-labs#22292

This was referenced Jul 13, 2022

restricts rent-paying accounts lifetime extension #26606

Merged

Feature Gate: restrict rent-paying accounts TTL extension #26607

Closed

This was referenced Nov 16, 2023

docs: Add Solana Playground quickstart page, and add examples page for anchor contraints and types. solana-foundation/anchor#2703

Merged

lang: Remove rent_exempt constraint solana-foundation/anchor#2708

Closed

acheroncrypto mentioned this pull request Dec 8, 2023

lang: Provide ability to make program owned account not rent exempt solana-foundation/anchor#204

Closed

brooksprumo mentioned this pull request Feb 7, 2024

Remove unnecessary usage of RentCollector #35121

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent rent-paying account creation#22292

Prevent rent-paying account creation#22292
CriesofCarrots merged 11 commits intosolana-labs:masterfrom
CriesofCarrots:prevent-rent-paying-account-creation

CriesofCarrots commented Jan 5, 2022 •

edited

Loading

Uh oh!

CriesofCarrots commented Jan 5, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

jstarry left a comment

Uh oh!

Uh oh!

CriesofCarrots commented Jan 7, 2022

Uh oh!

jstarry left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryoqun commented Jan 10, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

CriesofCarrots commented Jan 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Summary of Changes

Uh oh!

CriesofCarrots commented Jan 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jstarry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CriesofCarrots commented Jan 7, 2022

Uh oh!

jstarry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryoqun commented Jan 10, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CriesofCarrots commented Jan 5, 2022 •

edited

Loading

CriesofCarrots commented Jan 5, 2022 •

edited

Loading