This repository was archived by the owner on Jan 22, 2025. It is now read-only.
checks for authorized voter early on in the vote-listener pipeline (backport #22169)#22188
Merged
mergify[bot] merged 2 commits intov1.8from Dec 30, 2021
Merged
checks for authorized voter early on in the vote-listener pipeline (backport #22169)#22188mergify[bot] merged 2 commits intov1.8from
mergify[bot] merged 2 commits intov1.8from
Conversation
…22169) Before votes are verified that they are signed by the authorized voter, they might be dropped in verified-vote-packets code. If there are enough many spam votes from unauthorized voters, this may potentially drop valid votes but keep the false ones. https://github.com/solana-labs/solana/blob/57986f982/core/src/verified_vote_packets.rs#L165-L168 (cherry picked from commit c0c6038) # Conflicts: # core/src/cluster_info_vote_listener.rs
Contributor
Author
|
automerge label removed due to a CI failure |
Contributor
Author
|
automerge label removed due to a CI failure |
ae7f6cf to
2725ae8
Compare
Codecov Report
@@ Coverage Diff @@
## v1.8 #22188 +/- ##
=========================================
- Coverage 81.6% 81.5% -0.1%
=========================================
Files 459 459
Lines 130909 130934 +25
=========================================
+ Hits 106826 106839 +13
- Misses 24083 24095 +12 |
Contributor
|
This PR has been automatically locked since there has not been any activity in past 14 days after it was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #22169 done by Mergify.
Cherry-pick of c0c6038 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com