checks for authorized voter early on in the vote-listener pipeline

[behzadnouri]

Problem

Before votes are verified that they are signed by the authorized voter,
they might be dropped in verified-vote-packets code. If there are
enough many spam votes from unauthorized voters, this may potentially
drop valid votes but keep the false ones.
https://github.com/solana-labs/solana/blob/57986f982/core/src/verified_vote_packets.rs#L165-L168

Summary of Changes

Check for authorized voter early on in the vote-listener pipeline

[carllin]

Now that we've moved the authorized voter check earlier, can we delete this later authorized voter check?

solana/core/src/cluster_info_vote_listener.rs

Lines 841 to 847 in e6deb59

	.filter_map(|gossip_tx| {
	vote_transaction::parse_vote_transaction(gossip_tx)
	.filter(|(vote_pubkey, vote, _)| {
	Self::filter_gossip_votes(vote_tracker, vote_pubkey, vote, gossip_tx)
	})
	.map(|v| (true, v))
	})

[behzadnouri]

Now that we've moved the authorized voter check earlier, can we delete this later authorized voter check?

solana/core/src/cluster_info_vote_listener.rs

Lines 841 to 847 in e6deb59

	.filter_map(|gossip_tx| {
	vote_transaction::parse_vote_transaction(gossip_tx)
	.filter(|(vote_pubkey, vote, _)| {
	Self::filter_gossip_votes(vote_tracker, vote_pubkey, vote, gossip_tx)
	})
	.map(|v| (true, v))
	})

yeah, I think we can remove that.
I will send a follow up change not to slow down merging this one.

[codecov]

Codecov Report

Merging #22169 (e6deb59) into master (b1d9a2e) will decrease coverage by 0.0%.
The diff coverage is 97.3%.

@@            Coverage Diff            @@
##           master   #22169     +/-   ##
=========================================
- Coverage    81.1%    81.1%   -0.1%     
=========================================
  Files         521      521             
  Lines      146316   146340     +24     
=========================================
+ Hits       118802   118810      +8     
- Misses      27514    27530     +16