This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Removes native loader entrypoints from the SDK#21185
Merged
Lichtso merged 1 commit intosolana-labs:masterfrom Nov 5, 2021
Merged
Removes native loader entrypoints from the SDK#21185Lichtso merged 1 commit intosolana-labs:masterfrom
Lichtso merged 1 commit intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21185 +/- ##
=======================================
Coverage 81.5% 81.6%
=======================================
Files 499 499
Lines 140244 140244
=======================================
+ Hits 114392 114448 +56
+ Misses 25852 25796 -56 |
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…the public interface. (solana-labs#21185)" This reverts commit 0379933.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
These two entrypoints are the last remaining connections that attach the SDK to the program runtime crate.
As the native loader is already prepared to be feature gated out, we can remove these from the public interface.
This PR is a preparation so that #21180 can fully separate the SDK and the program runtime crate.
Summary of Changes
The two entrypoints were moved from the SDK to the program-runtime crate.
Meaning they can still be used for loading existing but not for the deployment of new programs anymore.
Fixes #