This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Refactor: Move sdk::process_instruction in program-runtime-crate#21180
Merged
Lichtso merged 6 commits intosolana-labs:masterfrom Nov 17, 2021
Merged
Conversation
Lichtso
force-pushed
the
refactor/move_process_instruction_in_program_runtime
branch
from
7ff9d4c to
1bf953c
Compare
…cros to log_collector.rs, and moves the stable_log to stable_log.rs
Lichtso
force-pushed
the
refactor/move_process_instruction_in_program_runtime
branch
from
60fc184 to
1134a51
Compare
Contributor
Author
|
I just rebased to avoid merge conflicts. Edit: Ah, yes a few things changed in the mean time, will update them accordingly. |
Lichtso
force-pushed
the
refactor/move_process_instruction_in_program_runtime
branch
from
1134a51 to
0ec8c65
Compare
Codecov Report
@@ Coverage Diff @@
## master #21180 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 500 500
Lines 140604 140604
=========================================
- Hits 114704 114684 -20
- Misses 25900 25920 +20 |
Lichtso
deleted the
refactor/move_process_instruction_in_program_runtime
branch
|
Is there some sort of guide on the various Solana crates? What you said about the code base being hard to understand rings very true to me, as I'm struggling to assign roles to various sub-packages like sdk, runtime, program-runtime, rpc, client, etc. |
Contributor
Author
|
There is no broad and coarse documentation of the source tree that I am aware of. |
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…ana-labs#21180) * Moves the Executor dyn Trait to instruction_processor.rs * Moves the Logger dyn Trait as well as the ic_msg and ic_logger_msg macros to log_collector.rs, and moves the stable_log to stable_log.rs * Moves the ComputeMeter dyn Trait to invoke_context.rs * Moves the InvokeContext dyn Trait and the ProcessInstructionWithContext type to invoke_context.rs * Updates cargo files. * Re-export InvokeContext in program-test Co-authored-by: Jon Cinque <jon.cinque@gmail.com>
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…ate (solana-labs#21180)" This reverts commit 837afda.
alessandrod
added a commit
to alessandrod/cargo-run-bpf-tests
that referenced
this pull request
Nov 26, 2021
InvokeContext is now in program-runtime, see solana-labs/solana#21180
alessandrod
added a commit
to anza-xyz/cargo-run-solana-tests
that referenced
this pull request
Nov 28, 2021
InvokeContext is now in program-runtime, see solana-labs/solana#21180
Closed
TalentCoder99
added a commit
to TalentCoder99/cargo-run-bpf-tests
that referenced
this pull request
Jun 26, 2022
InvokeContext is now in program-runtime, see solana-labs/solana#21180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Various program execution related structs, methods, types and traits are still in the SDK, but don't need to be part of the public interface. The code base is currently hard to understand because the relevant parts are spread across the runtime, sdk and the program-runtime crate.
Summary of Changes
Moves everything from
sdk::process_instructioninto the program-runtime-crate.Fixes #