This repository was archived by the owner on Jan 22, 2025. It is now read-only.
client: Add retry logic on Pubsub 429 error during connect#19990
Merged
joncinque merged 1 commit intosolana-labs:masterfrom Sep 18, 2021
Merged
client: Add retry logic on Pubsub 429 error during connect#19990joncinque merged 1 commit intosolana-labs:masterfrom
joncinque merged 1 commit intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19990 +/- ##
========================================
Coverage 82.6% 82.6%
========================================
Files 478 480 +2
Lines 133547 133674 +127
========================================
+ Hits 110369 110514 +145
+ Misses 23178 23160 -18 |
mergify Bot
pushed a commit
that referenced
this pull request
Sep 18, 2021
(cherry picked from commit e9b066d)
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit 063a6ac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The pubsub client can give a 429 (TOO_MANY_REQUESTS) when trying to connect, causing avoidable failures to users.
Summary of Changes
Respect the backoff from a 429, and retry the connection after waiting. This mimics the send retry logic at
solana/client/src/http_sender.rs
Lines 96 to 117 in 74cc2e5
Fixes #