Apply the retry code to the async pubsub client

[steveluscher]

Four years ago, retry was added to the sync client. Never to the async client.

UNTIL TODAY.

Test plan

Create a test server

import http from "http";

import { WebSocketServer } from "ws";

let attemptCount = 0;

const server = http.createServer();
const wss = new WebSocketServer({ noServer: true });

wss.on("connection", (ws) => {
  ws.send("Connection accepted.");
  ws.on("message", (msg) => console.log(`Received: ${msg}`));
});

server.on("upgrade", (req, socket, head) => {
  attemptCount += 1;

  if (attemptCount <= 4) {
    socket.write("HTTP/1.1 429 Too Many Requests\r\n\r\n");
    socket.destroy();
    console.log(`Rejected connection #${attemptCount} (429)`);
    return;
  }

  wss.handleUpgrade(req, socket, head, (ws) => {
    wss.emit("connection", ws, req);
    console.log("Connection accepted on attempt", attemptCount);
  });
});

server.listen(8080, () => {
  console.log("Server listening on port 8080");
});

Run test_slot_subscription_async:

Rejected connection #1 (429)
Rejected connection #2 (429)
Rejected connection #3 (429)
Rejected connection #4 (429)
Connection accepted on attempt 5
Received: {"id":1,"jsonrpc":"2.0","method":"slotSubscribe","params":[]}

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.1%. Comparing base (0199a3a) to head (6f0e8e8).
⚠️ Report is 50 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #8503    +/-   ##
========================================
  Coverage    83.1%    83.1%            
========================================
  Files         840      840            
  Lines      367669   367698    +29     
========================================
+ Hits       305719   305875   +156     
+ Misses      61950    61823   -127     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[joncinque]

Looks good to me! Just the nit on naming, which you can take or leave

[anza-team]

😱 New commits were pushed while the automerge label was present.

[joncinque]

Looks great, thanks!