This repository was archived by the owner on Jan 22, 2025. It is now read-only.
retains crds values if the origin is still active (backport #16576)#16771
Merged
mergify[bot] merged 1 commit intov1.6from Apr 23, 2021
Merged
retains crds values if the origin is still active (backport #16576)#16771mergify[bot] merged 1 commit intov1.6from
mergify[bot] merged 1 commit intov1.6from
Conversation
Local timestamps are updated for records associated with a pubkey if the origin is still active: https://github.com/solana-labs/solana/blob/c8ed14c64/core/src/crds.rs#L301-L311 However this is done inconsistently on some gossip paths (pull requests and pull responses) but not all (e.g. push messages). Additionally update_record_timestamp is inefficient since there can be ~800 values associated with each pubkey. This commit updates records timestamps only on contact-infos; and, instead utilizes origin's timestamp when purging old values. (cherry picked from commit 2c82f21)
mergify
Bot
added
automerge
Contributor
Author
|
automerge label removed due to a CI failure |
mergify
Bot
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## v1.6 #16771 +/- ##
========================================
Coverage 82.9% 82.9%
========================================
Files 414 416 +2
Lines 114017 114525 +508
========================================
+ Hits 94544 95021 +477
- Misses 19473 19504 +31 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #16576 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/