This repository was archived by the owner on Jan 22, 2025. It is now read-only.
retains crds values if the origin is still active#16576
Merged
behzadnouri merged 2 commits intosolana-labs:masterfrom Apr 23, 2021
Merged
retains crds values if the origin is still active#16576behzadnouri merged 2 commits intosolana-labs:masterfrom
behzadnouri merged 2 commits intosolana-labs:masterfrom
Conversation
behzadnouri
force-pushed
the
update-record-timestamps
branch
from
aa809f0 to
7a813bf
Compare
Codecov Report
@@ Coverage Diff @@
## master #16576 +/- ##
=======================================
Coverage 82.9% 82.9%
=======================================
Files 416 416
Lines 115439 115477 +38
=======================================
+ Hits 95784 95831 +47
+ Misses 19655 19646 -9 |
behzadnouri
force-pushed
the
update-record-timestamps
branch
2 times, most recently
from
872c9bf to
4fcac53
Compare
behzadnouri
force-pushed
the
update-record-timestamps
branch
from
e9f2851 to
a155f70
Compare
Local timestamps are updated for records associated with a pubkey if the origin is still active: https://github.com/solana-labs/solana/blob/c8ed14c64/core/src/crds.rs#L301-L311 However this is done inconsistently on some gossip paths (pull requests and pull responses) but not all (e.g. push messages). Additionally update_record_timestamp is inefficient since there can be ~800 values associated with each pubkey. This commit updates records timestamps only on contact-infos; and, instead utilizes origin's timestamp when purging old values.
behzadnouri
force-pushed
the
update-record-timestamps
branch
from
a155f70 to
82616e0
Compare
carllin
approved these changes
Apr 22, 2021
Contributor
carllin
left a comment
carllin
left a comment
There was a problem hiding this comment.
Nice!
Small disambiguation on the problem description: by "origin timestamp" we don't mean the timestamp marked by the original sender, we mean the timestamp from the last refresh on the origin's CrdsValueLabel::ContactInfo, which is now refreshed on every message update from that origin.
Contributor
Author
yeah, that is correct |
mergify Bot
pushed a commit
that referenced
this pull request
Apr 23, 2021
Local timestamps are updated for records associated with a pubkey if the origin is still active: https://github.com/solana-labs/solana/blob/c8ed14c64/core/src/crds.rs#L301-L311 However this is done inconsistently on some gossip paths (pull requests and pull responses) but not all (e.g. push messages). Additionally update_record_timestamp is inefficient since there can be ~800 values associated with each pubkey. This commit updates records timestamps only on contact-infos; and, instead utilizes origin's timestamp when purging old values. (cherry picked from commit 2c82f21)
mergify Bot
added a commit
that referenced
this pull request
Apr 23, 2021
Local timestamps are updated for records associated with a pubkey if the origin is still active: https://github.com/solana-labs/solana/blob/c8ed14c64/core/src/crds.rs#L301-L311 However this is done inconsistently on some gossip paths (pull requests and pull responses) but not all (e.g. push messages). Additionally update_record_timestamp is inefficient since there can be ~800 values associated with each pubkey. This commit updates records timestamps only on contact-infos; and, instead utilizes origin's timestamp when purging old values. (cherry picked from commit 2c82f21) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local timestamps are updated for records associated with a pubkey if the
origin is still active:
https://github.com/solana-labs/solana/blob/c8ed14c64/core/src/crds.rs#L301-L311
However this is done inconsistently on some gossip paths (pull requests
and pull responses) but not all (e.g. push messages). Additionally
update_record_timestamp is inefficient since there can be ~800 values
associated with each pubkey.
This commit updates records timestamps only on contact-infos; and,
instead utilizes origin's timestamp when purging old values.
Summary of Changes