This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add more comments in Stakes::store for its subtlety#14065
Merged
ryoqun merged 2 commits intosolana-labs:masterfrom Dec 11, 2020
Merged
Add more comments in Stakes::store for its subtlety#14065ryoqun merged 2 commits intosolana-labs:masterfrom
ryoqun merged 2 commits intosolana-labs:masterfrom
Conversation
ryoqun
commented
Dec 11, 2020
| // unconditionally remove existing at first; there is no dependent calculated state for | ||
| // votes, not like stakes (stake codepath maintains calculated stake value grouped by | ||
| // delegated vote pubkey) | ||
| let old = self.vote_accounts.remove(pubkey); |
ryoqun
commented
Dec 11, 2020
| } | ||
| None | ||
| } else { | ||
| // there is no need to remove possibly existing Stakes cache entries with given |
Contributor
Author
There was a problem hiding this comment.
@CriesofCarrots Account::default() was hitting here in #14062.
ryoqun
changed the title
Contributor
Author
|
@bennofs I hope you glanced this code, considering #14062 finding. Could you check my sanity as a neutral outsider? There should be no hole anymore for Stakes with #14062 (@CriesofCarrots thanks for working on this) :) Also note that this is possibly reward-able effort. I cannot earn attack bonus; but you can by pointing my overlook.. :) |
Codecov Report
@@ Coverage Diff @@
## master #14065 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 384 384
Lines 94601 94601
=========================================
- Hits 77718 77712 -6
- Misses 16883 16889 +6 |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 11, 2020
* Add more comments in Stakes::store for its subtlety * more comment tweak (cherry picked from commit 7078a6a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Stakes::store() does its elegance without much murmuring regarding the handling of proper stale state prevention for stakes and votes.
Summary of Changes
Make it chatty for peaceful future humanity.
no functional change.
Fixes #