Filter out stake and vote accounts with incorrect owners

[CriesofCarrots]

Problem

Follow up to #13615
While the stake program now checks whether a vote account is correctly owned on Delegation, the runtime method to collect stake and vote accounts doesn't verify whether this is still the case.

Summary of Changes

Filter out invalid stake and vote accounts

[codecov]

Codecov Report

Merging #14062 (b336e84) into master (f02d4cd) will increase coverage by 0.0%.
The diff coverage is 94.0%.

@@           Coverage Diff            @@
##           master   #14062    +/-   ##
========================================
  Coverage    82.1%    82.1%            
========================================
  Files         381      381            
  Lines       94076    94211   +135     
========================================
+ Hits        77291    77407   +116     
- Misses      16785    16804    +19     

[ryoqun]

@CriesofCarrots btw, did you tested this manually?:

Well, I have a secret sauce of easily creating fake account via the wracked solana deploy command:

$ ./target/release/solana --url http://localhost:8899 account -o vote.data <foo bar pubkey json>
$ hexedit
$ ./target/release/solana.bad-deploy deploy --url http://localhost:8899/ vote.data <foo bar pubkey json>

diff --git a/cli/src/cli.rs b/cli/src/cli.rs
index aa7b69fb7c..e1ee8aa66b 100644
--- a/cli/src/cli.rs
+++ b/cli/src/cli.rs
@@ -1227,8 +1227,8 @@ fn do_process_deploy(
         CliError::DynamicProgramError(format!("Unable to read program file: {}", err))
     })?;
 
-    Executable::<BPFError>::from_elf(&program_data, Some(|x| bpf_verifier::check(x, true)))
-        .map_err(|err| CliError::DynamicProgramError(format!("ELF error: {}", err)))?;
+    //Executable::<BPFError>::from_elf(&program_data, Some(|x| bpf_verifier::check(x, true)))
+    //    .map_err(|err| CliError::DynamicProgramError(format!("ELF error: {}", err)))?;
 
     let loader_id = if use_deprecated_loader {
         bpf_loader_deprecated::id()

this is not strict requirement, though. :)

[ryoqun]

lgtm after metrics addition and small test tweaks!

Really thanks for taking this over. :)

[ryoqun]

Well, I have a secret sauce...

@CriesofCarrots And this for faster inflation:

SOLANA_RUN_SH_CLUSTER_TYPE=mainnet-beta/development SOLANA_RUN_SH_GENESIS_ARGS="--slots-per-epoch 128 --vote-commission-percentage=55" ./run.sh

Pull request has been modified.

[CriesofCarrots]

@ryoqun thanks for the special sauce! It took a few more steps, but I was able to test this manually. Merging!