This repository was archived by the owner on Jan 22, 2025. It is now read-only.
cleanup accounts shrink debug message#13089
Merged
sakridge merged 1 commit intosolana-labs:masterfrom Oct 23, 2020
Merged
Conversation
ryoqun
reviewed
Oct 23, 2020
| } | ||
| if alive_count == stored_count && stores.values().len() == 1 { | ||
| trace!( | ||
| "shrink_stale_slot: not able to shrink at all{}: {} / {}", |
Contributor
There was a problem hiding this comment.
err, last minute change at my #12110 broke this log... ;)
Codecov Report
@@ Coverage Diff @@
## master #13089 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 366 366
Lines 86335 86335
=======================================
+ Hits 70955 70965 +10
+ Misses 15380 15370 -10 |
Contributor
I quickly checked |
mergify Bot
pushed a commit
that referenced
this pull request
Oct 23, 2020
(cherry picked from commit 7d2729f)
mergify Bot
pushed a commit
that referenced
this pull request
Oct 23, 2020
(cherry picked from commit 7d2729f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Shrink message could be more informative and better formatted.
Summary of Changes
Add slot and fix
<alive> / <storedto make sense with(forced)optional at the end.Fixes #