This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Prevent unbound memory growth by blockstore_processor#12110
Merged
ryoqun merged 5 commits intosolana-labs:masterfrom Sep 9, 2020
Merged
Prevent unbound memory growth by blockstore_processor#12110ryoqun merged 5 commits intosolana-labs:masterfrom
ryoqun merged 5 commits intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12110 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 337 337
Lines 79182 79205 +23
=========================================
+ Hits 64994 65001 +7
- Misses 14188 14204 +16 |
carllin
previously approved these changes
Sep 8, 2020
Contributor
|
ah doh! good catch on the |
mergify
Bot
dismissed
carllin’s stale review
Pull request has been modified.
mergify Bot
pushed a commit
that referenced
this pull request
Sep 9, 2020
* Prevent unbound memory growth by blockstore_processor * Promote log to info! considering infrequency * Exclude the time of freeing from interval... * Skip not-shrinkable slots even if forced * Add comment (cherry picked from commit c274e26)
mergify Bot
added a commit
that referenced
this pull request
Sep 9, 2020
* Prevent unbound memory growth by blockstore_processor * Promote log to info! considering infrequency * Exclude the time of freeing from interval... * Skip not-shrinkable slots even if forced * Add comment (cherry picked from commit c274e26) Co-authored-by: Ryo Onodera <ryoqun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#11727 wasn't enough. When replaying large number of slots, the memory growth is unbound at relatively quick rate.
Summary of Changes
Free any garbage resource laying around AccountsDB and really
Drop::drop()banks by cleaning them fromall_bankstoo.Context
found via capitalization work.