Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Moar rolling upgrade#12390

Closed
ryoqun wants to merge 10 commits intosolana-labs:masterfrom
ryoqun:moar-rolling-upgrade
Closed

Moar rolling upgrade#12390
ryoqun wants to merge 10 commits intosolana-labs:masterfrom
ryoqun:moar-rolling-upgrade

Conversation

@ryoqun
Copy link
Copy Markdown
Contributor

@ryoqun ryoqun commented Sep 22, 2020

Problem

testing upgrade version test is hard and required local patches to be merged into stable and beta release channels
and supporting the combination of newer net/*.sh and older validator seems tedious and basically unmaintained.

Summary of Changes

basic idea is like this

  1. git reset --hard $HEAD_OF_STABLE_OR_WHATEVER_PR_ON_STABLE_BRANCH
  2. build locally
  3. scp binaries
  4. ./net/start.sh ...
  5. git reset --hard $HEAD_OF_BETA_OR_WHATEVER_PR_ON_STABLE_BRANCH
  6. build locally
  7. scp binaries
  8. ./net/start.sh ...

This is reboot of #9212 op top of #12337 . #9212 originally closed without merging because building local version is supported without that pr. But now we want to support to building multiple versions locally. So I think this justifies the need of this pr.

Fixes #

@ryoqun ryoqun marked this pull request as draft September 22, 2020 09:08
@ryoqun ryoqun force-pushed the moar-rolling-upgrade branch from 940e78a to 82cd836 Compare September 22, 2020 13:19
@ryoqun
Copy link
Copy Markdown
Contributor Author

ryoqun commented Sep 22, 2020

@t-nelson Yay, this worked nicely: https://buildkite.com/solana-labs/rolling-upgrade-tests/builds/113

with

CHANNEL=local
LOCAL_BUILD_BRANCH=pull/12387/head
UPGRADE_CHANNEL=local
UPGRADE_LOCAL_BUILD_BRANCH=v1.3

So, the rolling upgrade test passed only when #12387 applied.

@ryoqun ryoqun requested a review from t-nelson September 22, 2020 14:22
@ryoqun ryoqun marked this pull request as ready for review September 22, 2020 14:22
@ryoqun
Copy link
Copy Markdown
Contributor Author

ryoqun commented Sep 22, 2020

supporting the combination of newer net/*.sh and older validator seems tedious and basically unmaintained.

Well, this pr currently doesn't solve this part

@t-nelson
Copy link
Copy Markdown
Contributor

Hey thanks for taking a stab at this. I have a somewhat embarrassing hack to get similar. We can actually avoid the local builds entirely, passing them off as optional buildkite jobs that store the release as artifacts. Then testnet-automation can resolve and download the right builds at runtime

Gross script: t-nelson@b17c75d

Buildkite:
Screen Shot 2020-09-22 at 10 39 03

@t-nelson
Copy link
Copy Markdown
Contributor

supporting the combination of newer net/*.sh and older validator seems tedious and basically unmaintained.

Well, this pr currently doesn't solve this part

Hehe, true. I believe this is one of our, perhaps unstated, devops goals, though. We no intention of actually supporting features back to stable, just that the master/HEAD scripts executing on the stable/HEAD bins should work. This mostly just means backporting hidden stubs so clap doesn't blow up when parsing the command line.

@ryoqun
Copy link
Copy Markdown
Contributor Author

ryoqun commented Sep 22, 2020

We can actually avoid the local builds entirely, passing them off as optional buildkite jobs that store the release as artifacts. ...

@t-nelson I see. Glad to see that you had similar one. Yeah, these're very similar. So, it seems that we can polish your separate buildkite job approach. Are you going to polish it at #12337? Alternatively, I can work on polishing it if you're busy with other things. :)

@t-nelson
Copy link
Copy Markdown
Contributor

@t-nelson I see. Glad to see that you had similar one. Yeah, these're very similar. So, it seems that we can polish your separate buildkite job approach. Are you going to polish it at #12337? Alternatively, I can work on polishing it if you're busy with other things. :)

I was hoping to get back to it after cleaning up the SPL Token CLI (probably EOW), but if you've got room on your plate, fee free to take over! I'll consolidate my changes into the branch pointed at #12337 (and rip out the junk debugging commits).

@stale
Copy link
Copy Markdown

stale Bot commented Sep 30, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale Bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Sep 30, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Oct 7, 2020

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale Bot closed this Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

stale [bot only] Added to stale content; results in auto-close after a week.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants