testnet-automation: More knobs for rolling upgrades by t-nelson · Pull Request #12337 · solana-labs/solana

t-nelson · 2020-09-18T20:34:41Z

Problem

1.2 -> 1.3 still falls over

Summary of Changes

Plumb genesis options to gain control over --cluster-type

ryoqun · 2020-09-22T16:08:46Z

@t-nelson Please take look at this: #12390 (comment) :)

t-nelson · 2020-09-23T03:51:00Z

@ryoqun I've dropped the junk commits here and picked in the custom build commits

~~102f7d2 can be dropped once #12405 and #12406 land~~ Dropped

6e9c14a may or may not be a good idea. It seemed to work, but I'm not sure if it'll break MacOS/Windows

ryoqun · 2020-09-23T18:33:40Z

+# Clone the specified committish
+git clone "$remote" "$tmp_source_dir"


Is there any reason we have to clone all new? I think we can add another worktree like this:

# Create temporal source dir to build git fetch origin "$branch" if [[ -n $commitish ]]; then git worktree add "$tmp_source_dir" $commitish else git worktree add "$tmp_source_dir" FETCH_HEAD fi

Nope! This was just a quick and dirty script to see if I could get what I wanted working (see script file name 😅). Plenty of optimizations to be had here

what a quick reply. :) I updated my comment by picking something from my attempt #12390. let's unify our work for the better. :)

this way we can build off at arbitrary commit, might be useful for building with fast-changing release branches.

ryoqun · 2020-09-23T18:36:23Z

+remote=https://github.com/solana-labs/solana.git
+
+cleanup_tmp_source_dir() {
+  rm -rf "$tmp_source_dir"


https://github.com/solana-labs/solana/pull/12337/files#r493804567 and do this?:

git worktree remove --force "$tmp_source_dir"

ryoqun · 2020-09-23T18:37:24Z

+    git fetch origin "$committish":branch_to_build
+    git checkout branch_to_build


this can be merged into https://github.com/solana-labs/solana/pull/12337/files#r493804567

ryoqun · 2020-09-23T18:48:37Z

  set -x
  # shellcheck disable=SC2086 # Don't want to double quote $rust_version
-  $cargo $maybeRustVersion build $maybeReleaseFlag "${binArgs[@]}"
+  $cargo $maybeRustVersion build $maybeReleaseFlag --bins


qq: why is this needed? because of shellcheck?

IIRC some bins were missing without

ryoqun · 2020-09-23T18:48:56Z

 mkdir -p "$installDir/bin"
-for bin in "${BINS[@]}"; do
-  cp -fv "target/$buildVariant/$bin" "$installDir"/bin
+for bin in "target/$buildVariant/"*; do


same as https://github.com/solana-labs/solana/pull/12337/files#r493815963

Idea here was basically to get rid of the manually specified bin list, so we don't have to maintain it

stale · 2020-09-30T23:16:01Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

This reverts commit d15f87d.

stale · 2020-10-17T02:26:54Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale · 2020-10-24T02:36:41Z

This stale pull request has been automatically closed. Thank you for your contributions.

stale · 2020-10-31T03:53:15Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale · 2020-11-09T18:31:46Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale · 2020-11-17T12:35:54Z

This stale pull request has been automatically closed. Thank you for your contributions.

t-nelson force-pushed the moar-rolling-upgrade branch 6 times, most recently from fbf9828 to ea41de4 Compare September 22, 2020 05:04

This was referenced Sep 22, 2020

Allow to run testnet-automation.sh directly from PRs #9212

Closed

Moar rolling upgrade #12390

Closed

t-nelson force-pushed the moar-rolling-upgrade branch from ea41de4 to 102f7d2 Compare September 23, 2020 03:22

t-nelson force-pushed the moar-rolling-upgrade branch from 102f7d2 to 6e9c14a Compare September 23, 2020 17:14

ryoqun reviewed Sep 23, 2020

View reviewed changes

stale Bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Sep 30, 2020

t-nelson force-pushed the moar-rolling-upgrade branch from c1bc6e1 to 1bdaf57 Compare October 9, 2020 04:16

stale Bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 9, 2020

t-nelson force-pushed the moar-rolling-upgrade branch from 1bdaf57 to 1acd93f Compare October 9, 2020 16:48

t-nelson added 8 commits October 9, 2020 19:30

testnet-automation: Plumb genesis options

f083495

forgive me

a4460b5

Let cargo build all bins

f3175a7

Fix bootstrap validator stake threshold wait

d0fdee0

Don't require tower

7f9556b

This variable holds a number not a list

e284c40

Debug

38a6267

New shellcheck image

ba68a03

t-nelson added 3 commits October 9, 2020 19:30

Really skip setup

d15f87d

Revert "Really skip setup"

284dc86

This reverts commit d15f87d.

hack

f44ad58

t-nelson force-pushed the moar-rolling-upgrade branch from 918f80a to f44ad58 Compare October 10, 2020 01:32

stale Bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 17, 2020

stale Bot closed this Oct 24, 2020

t-nelson removed the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 24, 2020

t-nelson reopened this Oct 24, 2020

stale Bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 31, 2020

t-nelson removed the stale [bot only] Added to stale content; results in auto-close after a week. label Nov 2, 2020

stale Bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Nov 9, 2020

stale Bot closed this Nov 17, 2020

t-nelson deleted the moar-rolling-upgrade branch March 2, 2021 21:11

		# Clone the specified committish
		git clone "$remote" "$tmp_source_dir"

		git fetch origin "$committish":branch_to_build
		git checkout branch_to_build

Conversation

t-nelson commented Sep 18, 2020

Problem

Summary of Changes

Uh oh!

ryoqun commented Sep 22, 2020

Uh oh!

t-nelson commented Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ryoqun Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stale Bot commented Sep 30, 2020

Uh oh!

stale Bot commented Oct 17, 2020

Uh oh!

stale Bot commented Oct 24, 2020

Uh oh!

stale Bot commented Oct 31, 2020

Uh oh!

stale Bot commented Nov 9, 2020

Uh oh!

stale Bot commented Nov 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

t-nelson commented Sep 23, 2020 •

edited

Loading

ryoqun Sep 23, 2020 •

edited

Loading