Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

validator/ cleanup#12340

Merged
mvines merged 2 commits intosolana-labs:masterfrom
mvines:drop
Sep 19, 2020
Merged

validator/ cleanup#12340
mvines merged 2 commits intosolana-labs:masterfrom
mvines:drop

Conversation

@mvines
Copy link
Copy Markdown
Contributor

@mvines mvines commented Sep 18, 2020 •
edited
Loading

validator/src/main.rs is messy, core/src/validator.rs is overexposed

Rearrange some code to make things a little tidier.

@mvines mvines force-pushed the drop branch 5 times, most recently from c8e437a to 0033df7 Compare September 18, 2020 23:14
@mvines mvines added the v1.3 label Sep 18, 2020
@mvines
Copy link
Copy Markdown
Contributor Author

mvines commented Sep 18, 2020

(adding v1.3 since there's a bunch of low-risk churn here and I don't want to deal merge conflicts for a couple months)

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 19, 2020 •
edited
Loading

Codecov Report

Merging #12340 into master will decrease coverage by 0.0%.
The diff coverage is 20.6%.

@@            Coverage Diff            @@
##           master   #12340     +/-   ##
=========================================
- Coverage    82.2%    82.2%   -0.1%     
=========================================
  Files         343      344      +1     
  Lines       81266    81278     +12     
=========================================
+ Hits        66825    66833      +8     
- Misses      14441    14445      +4

@ryoqun ryoqun mentioned this pull request Sep 19, 2020
Merged
1 task
@mvines mvines merged commit 208dd1d into solana-labs:master Sep 19, 2020
@mvines mvines deleted the drop branch September 19, 2020 15:36
@mergify mergify Bot mentioned this pull request Sep 19, 2020
Merged
mergify Bot added a commit that referenced this pull request Sep 19, 2020
@mergify @mvines
validator/ cleanup (bp #12340) (#12352)
a26e1f6 
* validator/ cleanup

(cherry picked from commit 1a03afc)

# Conflicts:
#	core/src/validator.rs

* Move TestValidator into its own module

(cherry picked from commit 208dd1d)

# Conflicts:
#	core/src/validator.rs
#	tokens/tests/commands.rs

* Rebase

Co-authored-by: Michael Vines <mvines@gmail.com>
@mvines mvines mentioned this pull request Sep 20, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mvines