This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Gate nonce-overwrite change#11081
Merged
mergify[bot] merged 1 commit intosolana-labs:masterfrom Jul 15, 2020
Merged
Conversation
Contributor
Author
|
v1.2 at #11079 |
Codecov Report
@@ Coverage Diff @@
## master #11081 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 319 319
Lines 73363 73367 +4
=========================================
- Hits 60282 60269 -13
- Misses 13081 13098 +17 |
mergify Bot
pushed a commit
that referenced
this pull request
Jul 15, 2020
(cherry picked from commit 1da9f9f)
CriesofCarrots
added a commit
that referenced
this pull request
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
(From #11032)
As of #10973 , a successful nonce transaction advances the nonce to the most recent blockhash from the RecentBlockhashes sysvar instead of re-overwriting that nonce with the most recent bank blockhash. We expect those hashes to be the same, but in fact that can be different in the final tick of the slot, due to this:
solana/runtime/src/bank.rs
Line 1255 in 1880621
This caused a bank hash mismatch on our api nodes.
We fixed the discrepancy, but that fix needs gating due to changing the bank. Therefore the overwrite also needs gating to avoid breaking anything while nodes are upgrading.
Summary of Changes
prepare_if_nonce_account()to gate overwrite in tandem with recent_blockhashes_sysvar_delay fix