Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Gate nonce-overwrite change#11081

Merged
mergify[bot] merged 1 commit intosolana-labs:masterfrom
CriesofCarrots:gate-nonce-utils
Jul 15, 2020
Merged

Gate nonce-overwrite change#11081
mergify[bot] merged 1 commit intosolana-labs:masterfrom
CriesofCarrots:gate-nonce-utils

Conversation

@CriesofCarrots
Copy link
Copy Markdown
Contributor

Problem

(From #11032)
As of #10973 , a successful nonce transaction advances the nonce to the most recent blockhash from the RecentBlockhashes sysvar instead of re-overwriting that nonce with the most recent bank blockhash. We expect those hashes to be the same, but in fact that can be different in the final tick of the slot, due to this:

if self.is_block_boundary(current_tick_height + 1) {

This caused a bank hash mismatch on our api nodes.

We fixed the discrepancy, but that fix needs gating due to changing the bank. Therefore the overwrite also needs gating to avoid breaking anything while nodes are upgrading.

Summary of Changes

  • Pass fix_recent_blockhashes_sysvar_delay into prepare_if_nonce_account() to gate overwrite in tandem with recent_blockhashes_sysvar_delay fix

@CriesofCarrots
Copy link
Copy Markdown
Contributor Author

v1.2 at #11079

@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Jul 15, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2020

Codecov Report

Merging #11081 into master will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #11081     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%     
=========================================
  Files         319      319             
  Lines       73363    73367      +4     
=========================================
- Hits        60282    60269     -13     
- Misses      13081    13098     +17     

@mergify mergify Bot merged commit 1da9f9f into solana-labs:master Jul 15, 2020
mergify Bot pushed a commit that referenced this pull request Jul 15, 2020
(cherry picked from commit 1da9f9f)
CriesofCarrots added a commit that referenced this pull request Jul 16, 2020
(cherry picked from commit 1da9f9f)

Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
@CriesofCarrots CriesofCarrots deleted the gate-nonce-utils branch July 24, 2020 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant