Gate advance-nonce change

[CriesofCarrots]

Problem

As of #10973 , a successful nonce transaction advances the nonce to the most recent blockhash from the RecentBlockhashes sysvar instead of re-overwriting that nonce with the most recent bank blockhash. We expect those hashes to be the same, but in fact that can be different in the final tick of the slot, due to this:

solana/runtime/src/bank.rs

Line 1255 in 1880621

if self.is_block_boundary(current_tick_height + 1) {

This caused a bank hash mismatch on our api nodes.

Summary of Changes

• Gate the change by operating mode/slot

Fixes #11020

[CriesofCarrots]

@mvines , we might be able to avoid the churn of this gating by fixing the discrepancy directly: #11020 (comment)
Thoughts?

[mvines]

@mvines , we might be able to avoid the churn of this gating by fixing the discrepancy directly: #11020 (comment)
Thoughts?

Sounds promising. That would just move the gating into bank.rs but would be an improvement to the accounts plumbing fo sure

[CriesofCarrots]

Made this change in order to unignore test_nonce_fee_calculator_updates

[codecov]

Codecov Report

Merging #11032 into master will increase coverage by 0.0%.
The diff coverage is 87.0%.

@@           Coverage Diff           @@
##           master   #11032   +/-   ##
=======================================
  Coverage    82.1%    82.2%           
=======================================
  Files         318      318           
  Lines       73249    73277   +28     
=======================================
+ Hits        60196    60236   +40     
+ Misses      13053    13041   -12