This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Expose SlotHistory::oldest() -> Slot#10799
Merged
ryoqun merged 1 commit intosolana-labs:masterfrom Jun 25, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10799 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 302 302
Lines 70855 70868 +13
=======================================
+ Hits 57975 57997 +22
+ Misses 12880 12871 -9 |
carllin
approved these changes
Jun 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is no convenient way to access how far old slots are available in SlotHistory.
Specifically needed by https://github.com/solana-labs/solana/pull/10718/files#diff-d848cba681535238849e7e33ed32702bR693
Summary of Changes
Expose the information and start dog-fooding internally also.
Context
Spawned from #10718