Replace abuse of promises with the queueMicrotask API in the RPC request coalescer
#3374
+10
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on |
steveluscher
commented
Oct 11, 2024
| expect.assertions(1); | ||
| coalescedTransport({ payload: null }).catch(() => {}); | ||
| await jest.runOnlyPendingTimersAsync(); | ||
| jest.runAllTicks(); |
There was a problem hiding this comment.
This is a simplification of these tests, but it should be noted that the tests in their pre-PR state also pass with the change to queueMicrotask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
queueMicrotaskAPI is well-supported enough now to use for this use case. https://caniuse.com/mdn-api_queuemicrotask