Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy over fast-stable-stringify tests from source #2501

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Copy over fast-stable-stringify tests from source #2501

merged 1 commit into from
Apr 17, 2024

Conversation

steveluscher
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 013e9b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@steveluscher Graphite App
Copy link
Collaborator Author

steveluscher commented Apr 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite Graphite

@socket-security Socket Security
Copy link

socket-security bot commented Apr 17, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 4.67 kB types

View full report↗︎

This was referenced Apr 17, 2024
Merged
Merged
Merged
@steveluscher steveluscher requested a review from lorisleiva April 17, 2024 00:38
@steveluscher steveluscher force-pushed the 04-17-copy_over_fast-stable-stringify_tests_from_source branch from f1b2a60 to 4631791 Compare April 17, 2024 00:52
steveluscher
steveluscher commented Apr 17, 2024
View reviewed changes
packages/fast-stable-stringify/package.json
Comment on lines -49 to -50
"test:unit:browser": "jest -c ../../node_modules/@solana/test-config/jest-unit.config.browser.ts --globalSetup @solana/test-config/test-validator-setup.js --globalTeardown @solana/test-config/test-validator-teardown.js --rootDir . --silent",
"test:unit:node": "jest -c ../../node_modules/@solana/test-config/jest-unit.config.node.ts --globalSetup @solana/test-config/test-validator-setup.js --globalTeardown @solana/test-config/test-validator-teardown.js --rootDir . --silent"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This never needed the test validator.

@steveluscher steveluscher force-pushed the 04-17-copy_over_fast-stable-stringify_tests_from_source branch from 4631791 to 013e9b3 Compare April 17, 2024 01:01
buffalojoec
buffalojoec reviewed Apr 17, 2024
View reviewed changes
packages/fast-stable-stringify/src/__tests__/index-test.ts
],
],
])('matches the output of `json-stable-stringify` when hashing %s (`%s`)', (_, value) => {
expect(stringify(value)).toBe(jsonStableStringify(value));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to bench this against anything else, like faster-stable-stringify or JSON.stringify?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original fast-stable-stringify tests verified its output against json-stable-stringify for correctness only.

I at least wanted to use that as a starting point so that as we make changes we can observe how they make ours diverge.

buffalojoec
buffalojoec reviewed Apr 17, 2024
View reviewed changes
packages/fast-stable-stringify/package.json
"test:unit:node": "jest -c ../../node_modules/@solana/test-config/jest-unit.config.node.ts --rootDir . --silent"
},
"devDependencies": {
"@types/json-stable-stringify": "^1.0.36",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why it needs the types, too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json-stable-stringify doesn't use TypeScript. You have to buy the types on the second hand market.

@steveluscher Graphite App
Copy link
Collaborator Author

steveluscher commented Apr 17, 2024 •
edited
Loading

Merge activity

@steveluscher steveluscher merged commit f396267 into master Apr 17, 2024
8 checks passed
@steveluscher steveluscher deleted the 04-17-copy_over_fast-stable-stringify_tests_from_source branch April 17, 2024 07:37
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.91.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buffalojoec buffalojoec buffalojoec left review comments

@lorisleiva lorisleiva lorisleiva approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveluscher @lorisleiva @buffalojoec