-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: downshift preflightCommitment
to processed
when bypassing preflight checks
#2415
fix: downshift preflightCommitment
to processed
when bypassing preflight checks
#2415
Conversation
🦋 Changeset detectedLatest commit: 7f406cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on Graphite |
c00f0c9
to
6199e68
Compare
6199e68
to
7f406cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
🎉 This PR is included in version 1.91.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Summary
There's a bug in the
sendTransaction
RPC method where, when bypassing preflight, we nevertheless materially use the value ofpreflightCommitment
to determine how to behave when sending the transaction.If you supply nothing – as you might think appropriate when skipping preflight – then the default of
finalized
will be used. Far from irrelevant, such a value can actually affect the retry behaviour of the send-transaction-service (STS). Read anza-xyz/agave#483 for more detail.In this PR, we try to get ahead of anza-xyz/agave#483 by setting this value to
processed
in the client. Until the server PR is deployed widely, this should cover those who choose to upgradeAddresses anza-xyz/agave#479
Test plan