Skip to content

Conversation

@amilz
Copy link
Contributor

@amilz amilz commented Oct 31, 2025

Update docs based on a few breaking changes related to #236 and #231

closes PRO-513, PRO-501


Important

Update documentation for fee payer policy controls and signer integration in Kora.

  • Fee Payer Policy Updates:
    • CLAUDE.md, CONFIGURATION.md, FEES.md, X402_DEMO_GUIDE.md: Introduce granular controls for fee payer actions, organized by program type (System, SPL Token, Token-2022).
    • Default all actions to false for security, with detailed descriptions of each control.
  • Signer Integration Guide:
    • ADDING_SIGNERS.md: Detailed step-by-step guide for adding new signers to Kora, including configuration, validation, and testing.
    • Instructions for updating solana-signers crate and Kora configuration.
  • Documentation Enhancements:
    • Update examples and configuration files to reflect new fee payer policy and signer integration processes.
    • Emphasize security considerations and best practices for configuration.

This description was created by Ellipsis for aba1a99. You can customize this summary. It will automatically update as commits are pushed.

amilz added 2 commits October 30, 2025 17:36
update based on using the solana signers crate
closes PRO-513
- update CLAUDE.md
- update CONFIGURATION.md
- update FEES.md
- update x402 guide

closes PRO-501
@amilz amilz self-assigned this Oct 31, 2025
@linear
Copy link

linear bot commented Oct 31, 2025

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to aba1a99 in 5 minutes and 16 seconds. Click for details.
  • Reviewed 1170 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. CLAUDE.md:415
  • Draft comment:
    There is a potential confusion: the intro states that fee payer policy defaults are set to false for security, yet the implementation details mention that Default implementations set fields to true for backward compatibility. Clarify this discrepancy.
  • Reason this comment was not posted:
    Comment was on unchanged code.
2. docs/contributors/ADDING_SIGNERS.md:68
  • Draft comment:
    Ensure that the naming (e.g. 'YourService') in the SignerTypeConfig variant and related configuration struct is consistent with the implementation in the solana-signers crate.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50% None
3. docs/operators/CONFIGURATION.md:284
  • Draft comment:
    The updated fee payer policy breakdown is very detailed. Double-check that all keys (system, system.nonce, spl_token, token_2022) exactly match the implementation in the code.
  • Reason this comment was not posted:
    Confidence changes required: 30% <= threshold 50% None
4. docs/operators/FEES.md:101
  • Draft comment:
    Verify that the expected security warning text for fixed pricing (with system.allow_transfer=true) is consistent with the implementation and other documentation sections.
  • Reason this comment was not posted:
    Confidence changes required: 40% <= threshold 50% None
5. docs/x402/demo/X402_DEMO_GUIDE.md:232
  • Draft comment:
    The demo setup is clear. Confirm that the instructions for starting Kora and the signers configuration align with the updated fee payer policy and signer docs.
  • Reason this comment was not posted:
    Confidence changes required: 30% <= threshold 50% None

Workflow ID: wflow_17MpRCMZb4lGEG4g

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@amilz amilz merged commit 3b6e988 into release/feature-freeze-for-audit Oct 31, 2025
@amilz amilz deleted the chore/docs-updates branch October 31, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants