Skip to content

Conversation

@dev-jodee
Copy link
Contributor

@dev-jodee dev-jodee commented Oct 9, 2025

Important

Replace custom Kora Signer with solana-signers crate, updating configurations, transaction handling, and error management.

  • Signer Replacement:
    • Replace custom KoraSigner with solana-signers crate across the codebase.
    • Update signer/config.rs, signer/pool.rs, and state.rs to use solana-signers.
    • Remove custom signer implementations from signer/memory_signer, signer/privy, signer/turnkey, and signer/vault.
  • Configuration:
    • Update SignerConfig in signer/config.rs to build signers using solana-signers.
    • Modify SignerPoolConfig to validate and initialize signers with the new library.
  • Transaction Handling:
    • Update transaction signing functions in transaction/versioned_transaction.rs to use solana-signers.
    • Ensure compatibility with VersionedTransactionResolved and related operations.
  • Error Handling:
    • Update KoraError conversions to handle solana-signers::SignerError.
    • Remove old error conversions related to custom signers.
  • Testing:
    • Update tests in tests/common/mod.rs and tests/config_mock.rs to reflect signer changes.
    • Ensure all tests pass with the new signer implementation.

This description was created by Ellipsis for 118ee80. You can customize this summary. It will automatically update as commits are pushed.

📊 Unit Test Coverage

Coverage

Unit Test Coverage: 84.4%

View Detailed Coverage Report

@dev-jodee dev-jodee requested a review from amilz October 9, 2025 19:13
@linear
Copy link

linear bot commented Oct 9, 2025

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 118ee80 in 1 minute and 4 seconds. Click for details.
  • Reviewed 4163 lines of code in 38 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. crates/lib/src/signer/pool.rs:153
  • Draft comment:
    It appears you are calling rand::rng() which is not available in rand 0.9. Consider using rand::thread_rng() and then using rng.gen_range(0..self.signers.len()) instead.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. crates/lib/src/signer/pool.rs:160
  • Draft comment:
    Similarly, in the weighted selection implementation, replace rand::rng() and rng.random_range() with rand::thread_rng() and rng.gen_range().
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. crates/lib/src/state.rs:22
  • Draft comment:
    Typo: The comment says "If client provided a signer signer_key...". Consider removing the redundant "signer" to just read "If client provided a signer_key...".
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_AJwbt9mFAA876kIh

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@dev-jodee dev-jodee merged commit 99af386 into release/feature-freeze-for-audit Oct 10, 2025
13 of 14 checks passed
@amilz amilz mentioned this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants