Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the readme for npm #1523

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

moser-jose
Copy link
Contributor

@moser-jose moser-jose commented Jan 25, 2021

Summary

Explain the motivation for making this change: here are some points to help you:

  • What issues does the pull request solve? Please tag them so that they will get automatically closed once the PR is merged
  • What is the feature? (if applicable)
  • How did you implement the solution?
  • What areas of the library does it impact?

Test Plan

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@WoLewicki
Copy link
Member

I ran prettier's format on README.md and it does not show such changes, so I believe the current styling is correct. Can you elaborate why this would be better?

@WoLewicki WoLewicki changed the base branch from develop to main July 25, 2022 10:24
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I can see that those changes were needed since they are added here too: #1782. Sorry, I must have run it on some other prettier config. Thanks for your contribution!

@WoLewicki WoLewicki merged commit c84b345 into software-mansion:main Jul 25, 2022
@moser-jose
Copy link
Contributor Author

Nice 👏🏻👏🏻👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants