Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CI for JS, iOS and Android formatting #1782

Merged
merged 17 commits into from
Aug 16, 2022

Conversation

WoLewicki
Copy link
Member

@WoLewicki WoLewicki commented Jun 2, 2022

Summary

Added CI workflow and local pre-commit hook for formatting and linting the newly added JS, iOS and Android code.

Test Plan

Check if the CI passes correctly.

.github/workflows/main.yml Outdated Show resolved Hide resolved
package.json Outdated
"format": "prettier README.md CONTRIBUTING.md CODE_OF_CONDUCT.md './src/**/*.{ts,tsx}' src/index.d.ts --write",
"format": "yarn format-js && yarn format-ios",
"format-ios": "find apple/ -iname *.h -o -iname *.m -o -iname *.cpp -o -iname *.mm | xargs clang-format -i",
"format-js": "prettier README.md CONTRIBUTING.md CODE_OF_CONDUCT.md './src/**/*.{ts,tsx}' './Example/**/*.{ts,tsx}' src/index.d.ts --write",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could do *.md to future prevent the script whenever new .md files would are added to the repo.

@WoLewicki WoLewicki mentioned this pull request Aug 12, 2022
@WoLewicki WoLewicki changed the title chore: add CI for JS and iOS formatting chore: add CI for JS, iOS and Android formatting Aug 16, 2022
@WoLewicki WoLewicki merged commit 98c14b4 into main Aug 16, 2022
@WoLewicki WoLewicki mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants