fix(web): reexport missing component #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetavg
added a commit
to onejs/one
that referenced
this pull request
Dec 17, 2024
Since we need this fix which is included in 4.4.0-rc.0 for web to work: software-mansion/react-native-screens#2535
zetavg
added a commit
to onejs/one
that referenced
this pull request
Dec 19, 2024
Since we need this fix which is included in 4.4.0-rc.0 for web to work: software-mansion/react-native-screens#2535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently
FooterComponentwas introduced for internal reasons, however it hasn't been exported on webleading to issues.
Caution
We need to set up CI for web...
Fixes #2534
Changes
FooterComponentis now exported fromScreenFooter.web.tsxTest code and steps to reproduce
??? We do not have a web example - we need to add it.
Checklist