ScreenFooter missing an export in web version #2534
Labels
Comments
github-actions
bot
added
Platform: Web
|
Hey! 👋 The issue doesn't seem to contain a minimal reproduction. Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem? |
|
Thanks! I need to setup CI for web... |
kkafar
added a commit
that referenced
this issue
Nov 22, 2024
## Description Recently `FooterComponent` was introduced for internal reasons, however it hasn't been exported on web leading to issues. > [!caution] > We need to set up CI for web... Fixes #2534 ## Changes `FooterComponent` is now exported from `ScreenFooter.web.tsx` ## Test code and steps to reproduce ??? We do not have a web example - we need to add it. ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
|
Hello! We were debugging the conflict and got to this fix, however its not installed by Yarn, seems to install the contents of @4.2.0 so we downgraded to @4.1.0 and it worked. Do you know why yarn would not be downloading the correct contents of this fix along with @4.3.0? Tried cleaning cache, nuking node_modules, changing terminals, nothing. If we missed something super obvious please enlighten us! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This commit (https://github.com/software-mansion/react-native-screens/pull/2504/files#diff-96fd20779df1dada3660b5dbaaeb48a45528b25c038ae5b621e19f2e2671fcc3R16) introduces a new export
FooterComponentinScreenFooterbut the web variant (https://github.com/software-mansion/react-native-screens/blob/main/src/components/ScreenFooter.web.tsx) does not have this, so if you mix react-navigation with screens on web you'll have an import errorcc: @kkafar
Steps to reproduce
Try and build a web app using navigation/screens and you'll see it complain there is no component exported by that name
Snack or a link to a repository
sorry
Screens version
4.3.0
React Native version
0.75.4
Platforms
Web
JavaScript runtime
None
Workflow
None
Architecture
None
Build type
None
Device
None
Device model
No response
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: