Merge ViewDescriptors implementation #6123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
commented
Jun 14, 2024
tjzel
requested changes
Jun 19, 2024
Collaborator
tjzel
left a comment
tjzel
left a comment
There was a problem hiding this comment.
Just blocking it for now because I know this code more in-depth and want to review it properly before we merge it. 🙏
48 tasks
tjzel
approved these changes
Jun 28, 2024
Collaborator
tjzel
left a comment
tjzel
left a comment
There was a problem hiding this comment.
We need some TS fixes for these changes in the pipeline, but it's of the least concern for now. Beside this, all is solid!
tomekzaw
reviewed
Jun 28, 2024
This was referenced Jul 25, 2024
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
## Summary The motivation behind this PR was the lack of animation in the web implementation when React.StrictMode was enabled. While debugging, I discovered we had two similar mechanisms for storing connection between components and animations: one for mobile animations and one for web animations. I realized that the native implementation worked flawlessly without any issues on the web as well, as it had been recently refactored to align with React's guidelines. I decided to remove the flawed web implementation and replace it with mobile implementation. ## Test plan 1. Open web-example and check if animations works. 2. Wrap any web example from example app with `<React.StrictMode></React.StrictMode>` and see if animations works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The motivation behind this PR was the lack of animation in the web implementation when React.StrictMode was enabled. While debugging, I discovered we had two similar mechanisms for storing connection between components and animations: one for mobile animations and one for web animations. I realized that the native implementation worked flawlessly without any issues on the web as well, as it had been recently refactored to align with React's guidelines. I decided to remove the flawed web implementation and replace it with mobile implementation.
Test plan
<React.StrictMode></React.StrictMode>and see if animations works.