Revert dynamic styles PR #6218
Merged
Revert dynamic styles PR #6218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
requested changes
Jul 8, 2024
Collaborator
tjzel
left a comment
tjzel
left a comment
There was a problem hiding this comment.
This is a sad day in the history of Reanimated - with this change we are going one step further from mimicking React with our API 😭.
We should add relevant information to our documentation about the fact the user can't change animated styles dynamically.
packages/react-native-reanimated/src/createAnimatedComponent/PropsFilter.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/src/createAnimatedComponent/PropsFilter.tsx
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Jul 8, 2024
tjzel
approved these changes
Jul 9, 2024
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
## Summary Unfortunately, turns out the PR with dynamic styles software-mansion#5268 introduced more problems than it solved. Thus, proposing a revert. This revert most likely fixed: - software-mansion#6203 - software-mansion#6102 - software-mansion#6037 as well as one more not-published issue and potentially a few more. ## Notes Even if it gets approved, to be merged ONLY after @tjzel agrees with everything ## Test plan 😢 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unfortunately, turns out the PR with dynamic styles #5268 introduced more problems than it solved. Thus, proposing a revert.
This revert most likely fixed:
as well as one more not-published issue and potentially a few more.
Notes
Even if it gets approved, to be merged ONLY after @tjzel agrees with everything
Test plan
😢 😭