Closed
Conversation
Collaborator
Author
|
RIP in peace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this PR is to add functionality of changing UI runtime checks (aka
_WORKLET) totruein worklets, an extension to/alternate solution of #4511.Notice that in the code I'm not traversing the worklet's tree to get
_WORKLETnodes to change them totrue- I'm just replacing substrings in worklet's code.The reason of that is the fact we don't have trees for worklets - only a given node and its code. We could change them into ASTs and then replace certain nodes, but this seems unnecessary according to my research - we would need to do following steps:
Those could be some time-consuming extra steps that don't seem to be really needed, since we expect every
_WORKLETin worklet's code to be a part of a boolean expression.Things I also did in this PR:
describeblocks (it just makes much more sense that way).TODO:
_WORKLETin non-worklets tofalse(probably, since I think I remember that was the chief issue).Test plan
I've added a whole new test suite for this functionality in plugins tests. Also ran Example app to see if it works properly.