Merged
Conversation
This was referenced May 31, 2023
t0ma5h
approved these changes
May 31, 2023
NikitaDudin
approved these changes
May 31, 2023
|
where i inject |
|
@tomekzaw is there an estimate to when this will get merged or should i just fork it 😁? |
samyos
approved these changes
Jun 1, 2023
kmagiera
approved these changes
Jun 5, 2023
Member
kmagiera
left a comment
There was a problem hiding this comment.
Interesting this has to be added in three places instead of just one, but what can you do 🤷
Member
Author
|
Once we merge #4523 it will be only two places (one for each platform), and once we cleanup runtime initialization hopefully it will be just one 😄 |
Co-authored-by: Tymoteusz Boba <tymoteusz.boba@swmansion.com>
14fb217 to
cc8531c
Compare
piaskowyk
approved these changes
Jun 6, 2023
Member
|
According to my investigation, in out code is possible to call worklet function before globals initialisation - |
|
Great to see this merged. Will it make it into a release soon? |
Member
Author
|
Yep, we're releasing 3.3.0 today. |
1 task
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4506 and fixes #4507.
Test plan